Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to display Digital Reveal Cookie management message in Modal video #313 #318

Merged
merged 7 commits into from
Jan 16, 2024

Conversation

Copy link

aem-code-sync bot commented Dec 20, 2023

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Dec 20, 2023

Page Scores Audits Google
/reveal-event PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video December 21, 2023 15:15 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video December 21, 2023 15:58 Inactive
@cogniSyb cogniSyb added the FR Functional requirement label Jan 2, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 9, 2024 16:08 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 9, 2024 17:16 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 13:58 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 14:20 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 14:38 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 14:49 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 15:33 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 15:40 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 15:44 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 15:48 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 15:57 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 16:01 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 16:06 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 16:20 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 16:23 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 16:27 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 16:31 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 11, 2024 16:35 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 12, 2024 08:55 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 12, 2024 09:04 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 313-digital-reveal-video January 12, 2024 09:48 Inactive
@cogniSyb cogniSyb marked this pull request as ready for review January 16, 2024 09:43
@cogniSyb cogniSyb merged commit 8edbca9 into develop Jan 16, 2024
2 checks passed
cogniSyb added a commit that referenced this pull request Jan 16, 2024
…#313 (#318)

* refactor low resolution banner
* refactor check of cookie setting
* add banner when no fallback video is present
* add background image, change color for banner, set document cookie on okay button
* add rounded corners to video
* split livestream code from embed

---------

Co-authored-by: Lakshmishri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR Functional requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants